Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't introduce parenthesis around SynPat.IsInst #1660

Closed
3 tasks
nojaf opened this issue Apr 17, 2021 · 0 comments · Fixed by #1664
Closed
3 tasks

Don't introduce parenthesis around SynPat.IsInst #1660

nojaf opened this issue Apr 17, 2021 · 0 comments · Fixed by #1664

Comments

@nojaf
Copy link
Contributor

nojaf commented Apr 17, 2021

Issue created from fantomas-online

Code

        match other with
        | :? Queue<'T> as y ->
            if this.Length <> y.Length then
                false
            else if this.GetHashCode() <> y.GetHashCode() then
                false
            else
                Seq.forall2 Unchecked.equals this y
        | _ -> false

Result

match other with
| :? (Queue<'T>) as y ->
    if this.Length <> y.Length then
        false
    else if this.GetHashCode() <> y.GetHashCode() then
        false
    else
        Seq.forall2 Unchecked.equals this y
| _ -> false

Problem description

Not sure why we add these parentheses around SynPat.IsInst.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 04/17/2021 11:23:36 - 26674f9

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant