Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad interaction between KeepIndentInBranch and MultiLambdaClosingNewLine #1715

Closed
3 tasks
Smaug123 opened this issue May 10, 2021 · 0 comments · Fixed by #1734
Closed
3 tasks

Bad interaction between KeepIndentInBranch and MultiLambdaClosingNewLine #1715

Smaug123 opened this issue May 10, 2021 · 0 comments · Fixed by #1734

Comments

@Smaug123
Copy link
Contributor

Issue created from fantomas-online

Code

module Foo =
    let bar () =
        let baz =
            []
            |> List.filter (fun ref ->
                if ref.Type <> "h" then false
                else
                let m = regex.Match ref.To
                m.Success && things |> Set.contains (m.Groups.[1].ToString ())
            )
        0

Result

module Foo =
    let bar () =
        let baz =
            []
            |> List.filter (fun ref ->
                if ref.Type <> "h" then
                    false
                else
                    let m = regex.Match ref.To

                    m.Success
                    && things |> Set.contains (m.Groups.[1].ToString ())
            )

        0

Problem description

The body of the else in the lambda has been indented, which I didn't expect given KeepIndentInBranch. Note that if I turn off MultiLambdaClosingNewLine, the correct thing happens and the else block is unindented, so it's probably specifically an interaction between those two settings.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 05/09/2021 13:45:10 - f10b822

    { config with
                SpaceBeforeUppercaseInvocation = true
                SpaceBeforeClassConstructor = true
                SpaceBeforeMember = true
                SpaceBeforeColon = true
                SpaceBeforeSemicolon = true
                AlignFunctionSignatureToIndentation = true
                AlternativeLongMemberDefinitions = true
                MultiLineLambdaClosingNewline = true
                KeepIndentInBranch = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants