Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fantomas adds space before colon when SpaceBeforeColon is false #1773

Closed
3 tasks
auduchinok opened this issue Jun 9, 2021 · 4 comments · Fixed by #1781
Closed
3 tasks

Fantomas adds space before colon when SpaceBeforeColon is false #1773

auduchinok opened this issue Jun 9, 2021 · 4 comments · Fixed by #1781

Comments

@auduchinok
Copy link
Contributor

Issue created from fantomas-online

Code

type T() =
    member x.P: int =
        let i: int = 1
        1

Result

type T() =
    member x.P : int =
        let i : int = 1
        1

Problem description

Please describe here the Fantomas problem you encountered.
Check out our Contribution Guidelines.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 06/09/2021 15:42:35 - a79ebea

Default Fantomas configuration

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

@realvictorprm
Copy link

Just ran into this one too, good to see I'm not mistaken 😅

@nojaf
Copy link
Contributor

nojaf commented Jun 10, 2021

Hello, this is actually by design and was introduced in #1420.
I would accept a PR to update the docs on this.
Otherwise, this can be closed.

@auduchinok
Copy link
Contributor Author

It wasn't like this in the code style previously, I believe we should discuss/fix it there first.

@auduchinok
Copy link
Contributor Author

@nojaf The code style has been fixed, see dotnet/docs#24643.

nojaf added a commit to nojaf/fantomas that referenced this issue Jun 19, 2021
nojaf added a commit that referenced this issue Jun 21, 2021
* Update space before colon separator for values. Fixes #1773.

* Update documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants