Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepIndentInBranch causing offside error in if condition #1812

Closed
2 tasks
Smaug123 opened this issue Jul 5, 2021 · 0 comments · Fixed by #1813
Closed
2 tasks

KeepIndentInBranch causing offside error in if condition #1812

Smaug123 opened this issue Jul 5, 2021 · 0 comments · Fixed by #1813

Comments

@Smaug123
Copy link
Contributor

Smaug123 commented Jul 5, 2021

Issue created from fantomas-online

Code

module Foo =
    let bar =

        if output.Exists && not (output.EnumerateFiles() |> Seq.isEmpty && onlyContainsFoobar output) then
            Error (FooBarBazError.ErrorCase output)
        else
        
        let blah =
            let x = y
            None
        
        {
            Hi = blah
        }
        |> Ok

Result

module Foo =
    let bar =

        if
            output.Exists
            && not (
                output.EnumerateFiles () |> Seq.isEmpty
                && onlyContainsFoobar output
            )
        then
            Error (FooBarBazError.ErrorCase output)
        else

        let blah =
            let x = y
            None

        { Hi = blah } |> Ok

Problem description

The indentation of the branch looks good to me here, but enabling KeepIndentInBranch has caused the if condition's indentation to change in an offside-error-causing way.

Without KeepIndentInBranch, the body formats validly, as follows:

        if
            output.Exists
            && not
                (
                    output.EnumerateFiles () |> Seq.isEmpty
                    && onlyContainsFoobar output
                )
        then

Extra information

  • [/] The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 07/05/2021 06:55:07 - f4e8286

    { config with
                MaxLineLength = 100
                SpaceBeforeUppercaseInvocation = true
                SpaceBeforeClassConstructor = true
                SpaceBeforeMember = true
                SpaceBeforeColon = true
                SpaceBeforeSemicolon = true
                IndentOnTryWith = true
                MultilineBlockBracketsOnSameColumn = true
                NewlineBetweenTypeDefinitionAndMembers = true
                AlignFunctionSignatureToIndentation = true
                AlternativeLongMemberDefinitions = true
                MultiLineLambdaClosingNewline = true
                DisableElmishSyntax = true
                KeepIndentInBranch = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

nojaf added a commit that referenced this issue Jul 5, 2021
…ssions. (#1813)

* Apply same alternative formatting for match expression as in if expressions. Fixes #1774.

* Reuse alternative expression formatting with KeepIndentInBranch. Fixes #1812.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants