Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space between identifier and then is lost #1816

Closed
3 tasks
Smaug123 opened this issue Jul 6, 2021 · 0 comments · Fixed by #1817
Closed
3 tasks

Space between identifier and then is lost #1816

Smaug123 opened this issue Jul 6, 2021 · 0 comments · Fixed by #1817

Comments

@Smaug123
Copy link
Contributor

Smaug123 commented Jul 6, 2021

Issue created from fantomas-online

Code

module Foo =
    let assertConsistent () : unit =
        if veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLong then
            ()
        else
            if foo = bar then
                ()
            else
                let leftSet = HashSet (FooBarBaz.keys leftThings)
                leftSet.SymmetricExceptWith (FooBarBaz.keys rightThings)
                |> ignore

Result

module Foo =
    let assertConsistent () : unit =
        if veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongthen
            ()
        elif foo = bar then
            ()
        else

        let leftSet = HashSet(FooBarBaz.keys leftThings)

        leftSet.SymmetricExceptWith(FooBarBaz.keys rightThings)
        |> ignore

Problem description

I believe this is only caused by the MaxLineLength and KeepIndentInBranch combination. We've lost the space that delimits the word then.

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas Master at 07/05/2021 12:36:44 - 7cde65d

    { config with
                MaxLineLength = 100
                MultilineBlockBracketsOnSameColumn = true
                MultiLineLambdaClosingNewline = true
                KeepIndentInBranch = true }

Did you know that you can ignore files when formatting from fantomas-tool or the FAKE targets by using a .fantomasignore file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants