Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment dropped in a multi-option match #1855

Closed
pbiggar opened this issue Aug 5, 2021 · 4 comments · Fixed by #1860
Closed

Comment dropped in a multi-option match #1855

pbiggar opened this issue Aug 5, 2021 · 4 comments · Fixed by #1860
Labels
bug (soundness)

Comments

@pbiggar
Copy link
Contributor

pbiggar commented Aug 5, 2021

Issue created from fantomas-online

Code

match x with
| "a" // still here
| "b" // VANISHES
| "c" -> "c"

Result

match x with
| "a" // still here
| "b"
| "c" -> "c"

Problem description

Formatting this code drops a comment

Options

Fantomas Master at 08/04/2021 06:29:48 - 4bfd258

Default Fantomas configuration
@pbiggar pbiggar changed the title <Insert meaningful title> Comment dropped in a multi-option match Aug 5, 2021
@knocte
Copy link
Contributor

knocte commented Aug 6, 2021

I think this is a dupe of #1677

@pbiggar
Copy link
Contributor Author

pbiggar commented Aug 6, 2021

Yeah, looks like it.

nojaf added a commit to nojaf/fantomas that referenced this issue Aug 10, 2021
@nojaf
Remove SynPat_Or as trivia node candidate. Fixes fsprojects#1855. Fixes
374a174 
fsprojects#1677.
@nojaf nojaf mentioned this issue Aug 10, 2021
Merged
nojaf added a commit that referenced this issue Aug 10, 2021
@nojaf
Remove SynPat_Or as trivia node candidate. (#1860)
3288200 
* Remove SynPat_Or as trivia node candidate. Fixes #1855. Fixes #1677.

* Update to Paket 6 and add global.json.
@nojaf
Copy link
Contributor

nojaf commented Aug 10, 2021

@pbiggar would you like a patch release with this fix?

@pbiggar
Copy link
Contributor Author

pbiggar commented Aug 10, 2021

@pbiggar would you like a patch release with this fix?

No thanks, this wasn't a major worry for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug (soundness)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove SynPat_Or as trivia node candidate. nojaf/fantomas
3 participants
@pbiggar @knocte @nojaf