Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space missing in curried function invocation of multiple params before 1st param #2087

Closed
1 of 3 tasks
knocte opened this issue Feb 13, 2022 · 1 comment
Closed
1 of 3 tasks

Comments

@knocte
Copy link
Contributor

knocte commented Feb 13, 2022

Issue created from fantomas-online

Code

module Foo =
    let Bar (baz1: int) (baz2: string) (baz3: string) (baz4: string) (baz5: string) =
        FooBarBaz(someFunc x) (someOtherFunc y)

Result

module Foo =
    let Bar (baz1: int) (baz2: string) (baz3: string) (baz4: string) (baz5: string) =
        FooBarBaz(someFunc x) (someOtherFunc y)

Expected Result

module Foo =
    let Bar (baz1: int) (baz2: string) (baz3: string) (baz4: string) (baz5: string) =
        FooBarBaz (someFunc x) (someOtherFunc y)

Problem description

This guideline is not being respected: dotnet/docs#28141

Extra information

  • The formatted result breaks by code.
  • The formatted result gives compiler warnings.
  • I or my company would be willing to help fix this.

Options

Fantomas master branch at 1/1/1990

Default Fantomas configuration

@nojaf
Copy link
Contributor

nojaf commented Feb 13, 2022

Thank you for this report.
Please use a direct link to the style guide (https://docs.microsoft.com/en-us/dotnet/fsharp/style-guide/formatting#formatting-application-expressions) to point out the inconsistency.
We don't really care about the conversation that led to this outcome from Fantomas point of view.
(add a link to the section of the guide that is not being respected, see Contribution Guidelines)

knocte pushed a commit to knocte/fantomas that referenced this issue Feb 13, 2022
nojaf pushed a commit that referenced this issue Feb 13, 2022
Fixes #2087

Co-authored-by: ijanus <emekamicro@gmail.com>
nojaf pushed a commit that referenced this issue Feb 13, 2022
Fixes #2087

Co-authored-by: ijanus <emekamicro@gmail.com>
nojaf pushed a commit that referenced this issue Feb 13, 2022
Fixes #2087

Co-authored-by: ijanus <emekamicro@gmail.com>
knocte added a commit to nblockchain/fantomless that referenced this issue Feb 16, 2022
knocte added a commit to nblockchain/fantomless that referenced this issue Feb 16, 2022
)

Fixes fsprojects#2087

Cherry-picked from upstream's
fsprojects@fd46ab0

Co-authored-by: ijanus <emekamicro@gmail.com>
knocte added a commit to nblockchain/fantomless that referenced this issue Feb 16, 2022
)

Fixes fsprojects#2087

Cherry-picked from upstream's
fsprojects@fd46ab0

Co-authored-by: ijanus <emekamicro@gmail.com>
nojaf pushed a commit that referenced this issue Feb 18, 2022
Fixes #2087

Co-authored-by: ijanus <emekamicro@gmail.com>
@nojaf nojaf closed this as completed in 6274245 Mar 4, 2022
jindraivanek pushed a commit to jindraivanek/fantomas that referenced this issue Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants