Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong comment placement #289

Closed
auduchinok opened this issue Jul 27, 2018 · 4 comments
Closed

Wrong comment placement #289

auduchinok opened this issue Jul 27, 2018 · 4 comments
Labels
bug (soundness)

Comments

@auduchinok
Copy link
Contributor

Formatting Program.fs:

type T() =
    let x = 123
//    override private x.ToString() = ""
//    override private x.ToString() = ""
module Program

type T() =
    let x = 123
@SteveGilham
Copy link

See also #247

@nojaf
Copy link
Contributor

nojaf commented Nov 2, 2018

I believe this is fixed now, looks fine online.

@nojaf
Copy link
Contributor

nojaf commented Nov 16, 2018

Problem still occurs when PreserveEndOfLine is true

nojaf added a commit to nojaf/fantomas that referenced this issue Nov 19, 2018
@nojaf
Fix for additional newline. fsprojects#289
5ebe20c
nojaf added a commit that referenced this issue Nov 19, 2018
@nojaf
Fix for additional newline. #289 (#356)
5165eb5
@nojaf
Copy link
Contributor

nojaf commented Nov 20, 2018

Fixed in 2.9.1, see online.

@nojaf nojaf closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug (soundness)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jindraivanek @nojaf @auduchinok @SteveGilham