Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes followed by unit literals aren't formatted properly #405

Closed
ForNeVeR opened this issue Jan 29, 2019 · 2 comments
Closed

Attributes followed by unit literals aren't formatted properly #405

ForNeVeR opened this issue Jan 29, 2019 · 2 comments
Labels
area-preserve-eol help wanted

Comments

@ForNeVeR
Copy link
Contributor

Description

I have this code:

[<assembly: AssemblyVersion("0.0.1.0")>]
[<assembly: InternalsVisibleTo("Nightwatch.Tests")>]
()

After formatting, it looks like this:

()[<assembly: AssemblyVersion("0.0.1.0")>]
[<assembly: InternalsVisibleTo("Nightwatch.Tests")>]

Fantomas shouldn't change the order of literals and attributes in this case.

Repro code

Here's the repro link, note PreserveEndOfLine.
@ForNeVeR ForNeVeR changed the title Attributes followed by unit literals aren't formatted improperly Attributes followed by unit literals aren't formatted properly Jan 29, 2019
@nojaf
Copy link
Contributor

nojaf commented Jan 29, 2019

Hello @ForNeVeR , in #390 we have decided to sunset --preserve-eol in the next major.
There is no issue if PreserveEndOfLine is false so it is unlikely this will be fixed by us.
I'm leaving it open in case anyone from the community wants to pick it up.

@nojaf
Copy link
Contributor

nojaf commented Jul 12, 2019

Not a problem anymore due to #434.

@nojaf nojaf closed this as completed Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-preserve-eol help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ForNeVeR @nojaf