Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't remove getters #733

Closed
knocte opened this issue Mar 27, 2020 · 6 comments
Closed

Shouldn't remove getters #733

knocte opened this issue Mar 27, 2020 · 6 comments

Comments

@knocte
Copy link
Contributor

knocte commented Mar 27, 2020

Issue created from fantomas-ui

Code

type Foo =
    abstract member Bar: Baz with get

Result

type Foo =
    abstract Bar: Baz

Options

Fantomas Next - 3.3.0-3/26/2020

Name Value
IndentOnTryWith false
IndentSpaceNum 4
KeepNewlineAfter false
MaxIfThenElseShortWidth 40
PageWidth 120
ReorderOpenDeclaration false
SemicolonAtEndOfLine false
SpaceAfterComma true
SpaceAfterSemicolon true
SpaceAroundDelimiter true
SpaceBeforeClassConstructor false
SpaceBeforeColon false
SpaceBeforeLowercaseInvocation true
SpaceBeforeMember false
SpaceBeforeParameter true
SpaceBeforeSemicolon false
SpaceBeforeUppercaseInvocation false
StrictMode false
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 137.0 DAI (137.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

gitcoinbot commented May 4, 2020

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 1 month from now.
Please review their action plans below:

1) bobface has been approved to start work.

......................................................

Learn more on the Gitcoin Issue Details page.

@Bobface
Copy link
Contributor

Bobface commented May 4, 2020

I verified Fantomas behaves this way, however it is not considered to be a bug as the code still compiles without the getter.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 137.0 DAI (137.0 USD @ $1.0/DAI) has been submitted by:

  1. @bobface

@knocte please take a look at the submitted work:


@knocte
Copy link
Contributor Author

knocte commented May 4, 2020

I already knew the code still compiles but I thought the API would change. However @Bobface also verified that this doesn't change the IL facade, thanks.

@knocte knocte closed this as completed May 4, 2020
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 137.0 DAI (137.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @Bobface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants