Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening brace for test missing #806

Closed
JonCanning opened this issue May 3, 2020 · 6 comments · Fixed by #807
Closed

Opening brace for test missing #806

JonCanning opened this issue May 3, 2020 · 6 comments · Fixed by #807

Comments

@JonCanning
Copy link

Issue created from fantomas-online

Please describe here fantomas problem you encountered

Code

[<Tests>]
let tests =
  testList "tests"
    [
      test "test" {
        Expect.equal true true "unexpected"
      }
    ]

Result

[<Tests>]
let tests =
    testList "tests" [ test "test" Expect.equal true true "unexpected" } ]

Options

Fantomas Next - 4.0.0-alpha-001-1/1/1990

Name Value
IndentSpaceNum 4
PageWidth 120
SemicolonAtEndOfLine false
SpaceBeforeParameter true
SpaceBeforeLowercaseInvocation true
SpaceBeforeUppercaseInvocation false
SpaceBeforeClassConstructor false
SpaceBeforeMember false
SpaceBeforeColon false
SpaceAfterComma true
SpaceBeforeSemicolon false
SpaceAfterSemicolon true
IndentOnTryWith false
SpaceAroundDelimiter true
MaxIfThenElseShortWidth 40
MaxInfixOperatorExpression 50
MaxRecordWidth 40
MaxArrayOrListWidth 40
MaxLetBindingWidth 40
MultilineBlockBracketsOnSameColumn false
NewlineBetweenTypeDefinitionAndMembers false
StrictMode false
@nojaf
Copy link
Contributor

nojaf commented May 3, 2020

Thanks for reporting this, sorry this slipped in.

@JonCanning
Copy link
Author

Thanks, when will this be released? I could really use an ionide update to support this

@nojaf
Copy link
Contributor

nojaf commented May 4, 2020

Well my plan was to release another alpha by the end of the week.
Once it is on NuGet, it can be updated in FsAutocomplete and then FsAutocomplete can be updated in Ionide-vs-code extension.

However, nothing prevents me from releasing this sooner.
In return, could you do the FsAutocomplete and Ionide part?

PS: I notice your original source contains:

[

]

You might be interested in the new setting MultilineBlockBracketsOnSameColumn.
This places the braces of a list on the same column. For example

@JonCanning
Copy link
Author

Sure

@nojaf
Copy link
Contributor

nojaf commented May 4, 2020

@JonCanning I released https://www.nuget.org/packages/Fantomas/4.0.0-alpha-004.
To get this in Ionide:

  • Bump the version in FSAutocomplete.
  • Afterwards: update the hash in ionide-vscode to the latest master commit of fsautocomplete. Similar to this PR.

Don't be worried when the CI fails on either one of those projects, that tends to happen from time to time.

@ErikSchierboom the fix for #785 is in there as well.

@ErikSchierboom
Copy link
Contributor

@nojaf Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants