Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all unit test whether the formatted code is valid #842

Closed
nojaf opened this issue May 19, 2020 · 4 comments · Fixed by #1048
Closed

Verify all unit test whether the formatted code is valid #842

nojaf opened this issue May 19, 2020 · 4 comments · Fixed by #1048

Comments

@nojaf
Copy link
Contributor

nojaf commented May 19, 2020

In light of #841, we should check whether each unit test is producing valid F# code.
We currently only compare afterwards if each test is matching the expected string.
This is not enough, bugs can still slip into this if the result is not valid.

//cc @knocte @Bobface

@knocte
Copy link
Contributor

knocte commented Jun 4, 2020

And in light of #868 maybe it should check for warnings too?

@nojaf
Copy link
Contributor Author

nojaf commented Jun 4, 2020

Yes, seems like a good idea.

@knocte
Copy link
Contributor

knocte commented Aug 19, 2020

The commit 17fa4cb doesn't seem to fix this issue, @nojaf typo in commit message?

@nojaf
Copy link
Contributor Author

nojaf commented Aug 19, 2020

Indeed, I tried to remove the link in (#1015) but the commit message still triggered closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants