Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract editorconfig code to separate NuGet package. #986

Closed
nojaf opened this issue Jul 24, 2020 · 2 comments · Fixed by #987
Closed

Extract editorconfig code to separate NuGet package. #986

nojaf opened this issue Jul 24, 2020 · 2 comments · Fixed by #987

Comments

@nojaf
Copy link
Contributor

nojaf commented Jul 24, 2020

Intro

The merging of the Fantomas.EditorConfig.Core (which is a fork of editorconfig) into Fantomas itself is not working out for JetBrains.
They need to strong name the dll and that has proven to be difficult.

Proposal

I suggest we create a new project Fantomas.EditorConfig (that depends on the regular editorconfig package) and move the CodeFormatter.ReadConfiguration and CodeFormatter.TryReadConfiguration over there.
Fantomas.CoreGlobalTool would then use this package.

Impact

This will impact mostly editors and maybe library authors.
Breaking changes:

  • CodeFormatter.ReadConfiguration and CodeFormatter.TryReadConfiguration will move.
  • FakeHelpers will require a configuration again.

Pinging @auduchinok @deviousasti @baronfel @Krzysztof-Cieslak @jindraivanek

@deviousasti
Copy link
Member

fantomas-cli should be unaffected by the change.
As for VS, I'm not consuming the nuget build, so it should be fine.
Maybe we can skip the ILRepack step, since its purpose is to merge the Fantomas.EditorConfig.Core assembly.

@nojaf
Copy link
Contributor Author

nojaf commented Jul 24, 2020

Yes, I'm planning on removing the ILRepack thing altogether.
fantomas-cli will indeed not be impacted as those things are shipped slightly different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants