You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The merging of the Fantomas.EditorConfig.Core (which is a fork of editorconfig) into Fantomas itself is not working out for JetBrains.
They need to strong name the dll and that has proven to be difficult.
Proposal
I suggest we create a new project Fantomas.EditorConfig (that depends on the regular editorconfig package) and move the CodeFormatter.ReadConfiguration and CodeFormatter.TryReadConfiguration over there.
Fantomas.CoreGlobalTool would then use this package.
Impact
This will impact mostly editors and maybe library authors.
Breaking changes:
CodeFormatter.ReadConfiguration and CodeFormatter.TryReadConfiguration will move.
fantomas-cli should be unaffected by the change.
As for VS, I'm not consuming the nuget build, so it should be fine.
Maybe we can skip the ILRepack step, since its purpose is to merge the Fantomas.EditorConfig.Core assembly.
Intro
The merging of the Fantomas.EditorConfig.Core (which is a fork of editorconfig) into Fantomas itself is not working out for JetBrains.
They need to strong name the dll and that has proven to be difficult.
Proposal
I suggest we create a new project
Fantomas.EditorConfig
(that depends on the regular editorconfig package) and move theCodeFormatter.ReadConfiguration
andCodeFormatter.TryReadConfiguration
over there.Fantomas.CoreGlobalTool would then use this package.
Impact
This will impact mostly editors and maybe library authors.
Breaking changes:
CodeFormatter.ReadConfiguration
andCodeFormatter.TryReadConfiguration
will move.Pinging @auduchinok @deviousasti @baronfel @Krzysztof-Cieslak @jindraivanek
The text was updated successfully, but these errors were encountered: