Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indent multiline yield expression #1001

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Indent multiline yield expression #1001

merged 1 commit into from
Aug 17, 2020

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Aug 14, 2020

Fixes #882

Smaug123
Smaug123 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@Smaug123 Smaug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Actions is warning about incomplete pattern matching, which is a bit odd - I thought that was a compile error.

@nojaf
Copy link
Contributor Author

nojaf commented Aug 17, 2020

That warning will be resolved by #1000.
I sorta merged in an update of FCS but didn't take a new SynExpr into account.

@nojaf nojaf merged commit ab5e8da into fsprojects:master Aug 17, 2020
@nojaf nojaf deleted the fix-882 branch August 17, 2020 12:26
@nojaf nojaf mentioned this pull request Sep 1, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Smaug123 Smaug123 Smaug123 approved these changes

@jindraivanek jindraivanek Awaiting requested review from jindraivanek

@JackMatusiewiczGR JackMatusiewiczGR Awaiting requested review from JackMatusiewiczGR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fantomas generating invalid F# when trying to format a list created with yields
2 participants
@nojaf @Smaug123