Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parenthesis for multiline SynPat.Tuple expression in SynBinding #1183

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 2, 2020

Fixes #824.

@nojaf nojaf merged commit 2f7d5b7 into fsprojects:master Oct 2, 2020
@nojaf nojaf deleted the fix-824 branch October 2, 2020 13:18
@auduchinok
Copy link
Contributor

auduchinok commented Oct 2, 2020

Off-topic: same indent for the = and the bound expression looks somewhat wrong for F# to me, I'd much prefer = on the previous line.

And about the PR itself: another approach could be having an additional indent instead of adding parens that are redundant with the original formatting:

let var1withAVeryLongLongLongLongLongLongName,
        var2withAVeryLongLongLongLongLongLongName =
    1, 2

@nojaf
Copy link
Contributor Author

nojaf commented Oct 2, 2020

Seems like a good thing to check with the two style guides, for now not breaking the code is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when formatting with config file
2 participants