Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature BlankLinesAroundNestedMultilineExpressions #1587

Merged
merged 3 commits into from
Apr 5, 2021

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Apr 3, 2021

Related to #1370.
I still haven't figured out what the boundaries of this setting are.
Full transparency, this might make it into v4.5 or it might be removed altogether.
This PR is an experiment and needs further triaging.

@Smaug123 would this be something GR would enable internally?

@nojaf nojaf force-pushed the poc/control-newlines-inner-bindings branch from 89224e5 to 5fed76b Compare April 3, 2021 15:30
@Smaug123
Copy link
Contributor

Smaug123 commented Apr 3, 2021

We would probably enable newlines around multiline expressions (as Fantomas currently does), yes.

@nojaf nojaf force-pushed the poc/control-newlines-inner-bindings branch from 5fed76b to 1bc721b Compare April 5, 2021 14:46
@nojaf nojaf marked this pull request as ready for review April 5, 2021 15:19
@nojaf nojaf changed the title Initial commit for setting NewlinesAroundInnerMultilineExpressions. Feature BlankLinesAroundNestedMultilineExpressions Apr 5, 2021
@nojaf nojaf merged commit 494693e into fsprojects:master Apr 5, 2021
@nojaf nojaf deleted the poc/control-newlines-inner-bindings branch April 5, 2021 15:28
@snuup
Copy link

snuup commented Apr 23, 2021

I have a question regarding BlankLinesAroundNestedMultilineExpressions:

In the web demo, I can turn this feature off, which gives the formatting result I desire.
Inside Visual Studio I cannot find this configuration (F# Formatting 0.8.4.)

Is there a possibility to configure this in Visual Studio?

@nojaf
Copy link
Contributor Author

nojaf commented Apr 24, 2021

Hello, this is a relatively new feature that has not been released in a stable version.
I'm unaware if this already found its way in the Visual Studio extension.
@deviousasti any ideas?

@deviousasti
Copy link
Member

I was sort of waiting for F# Lint to finish the move to FCS 39 because Fantomas requiring FCS 39 would cause it to crash.
I guess I'll deploy it now and try the scream test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants