Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP keep \t escaped inside strings #1697

Merged
merged 2 commits into from
May 6, 2021
Merged

WIP keep \t escaped inside strings #1697

merged 2 commits into from
May 6, 2021

Conversation

stanciuadrian
Copy link
Contributor

Closes #1695.
WIP

nojaf
nojaf requested changes May 5, 2021
View reviewed changes
src/Fantomas.Tests/SynConstTests.fs Outdated Show resolved Hide resolved
nojaf
nojaf approved these changes May 6, 2021
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nojaf nojaf merged commit 26af26e into fsprojects:master May 6, 2021
@stanciuadrian
Copy link
Contributor Author

Thanks for the mentoring.
It's a friendly project for first-timers.

@nojaf
Copy link
Contributor

nojaf commented May 6, 2021

Those are kind words, my gratitude!
If you want to learn more about developing Fantomas, I'd launched a video series a while ago.
The main idea is that it should be possible to solve your bugs giving some guidance. Happy to see this in practise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

\t in string replaced by ASCII 9
2 participants
@stanciuadrian @nojaf