Retain significant whitespace in nested, indented #if directives #1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
approved these changes
Aug 19, 2021
|
No problem at all @nojaf - I hope you're having a great break! No need for a release for me yet. I've got a few more fixes to do before Fantomas can successfully format our (complex) code base. |
|
Hi @kentcb, how are things going for you? |
|
Hi @nojaf! Thanks for following up. Unfortunately (fortunately?), I spend a limited amount of time on open source work these days, and I've prioritized some other projects ahead of these changes. I do plan on getting back to them, but might be a little while before I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was tricky to debug, at least for me. The root of the problem was that
getTokenizedHashes' innerprocessLinefunction was rewriting some tokens with an offset, but not adjusting others. This meant that the significant whitespace ended up before the#ifrather than after it where it belonged.Fixes #1866