-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config documentation #1956
Merged
Merged
Config documentation #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
added a commit
that referenced
this pull request
Nov 7, 2021
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
@deviousasti this was published in 4.6.0-alpha-007. |
Thanks. I'll try it out. |
nojaf
added a commit
that referenced
this pull request
Nov 9, 2021
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Nov 10, 2021
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Nov 19, 2021
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Nov 24, 2021
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Dec 4, 2021
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Dec 29, 2021
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Jan 7, 2022
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Jan 8, 2022
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Jan 8, 2022
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Jan 14, 2022
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
nojaf
added a commit
that referenced
this pull request
Jan 14, 2022
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
jindraivanek
pushed a commit
to jindraivanek/fantomas
that referenced
this pull request
Mar 30, 2022
* Add documentation attribute * Expose documentation attributes via Fantomas Daemon. Co-authored-by: Asti <rahul.ramakumar@walmart.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the configuration meta information to the Fantomas Daemon.
The configuration response would look like:
You cannot assume that
category
,displayName
ordescription
will be present as there are versions out in the wild that don't contain these fields.@deviousasti I'm going to close #1931 in favour of this PR.
This does not mean we cannot revisit certain descriptions or other values.