apply spacing between operators and all SynExpr.Const #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baronfel
commented
Nov 24, 2021
| @@ -1226,3 +1226,40 @@ module Foo = | |||
| | true -> id | |||
| | false -> id) | |||
| """ | |||
|
|
|||
| let operator_application_literal_values = | |||
There was a problem hiding this comment.
I took this list of literals from the F# docs page, but strictly speaking it's not necessary. If we wanted to vary the behavior of the spacing then we'd use this to validate that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1979 by forcing the use of a space between all Prefix Applications (typically operators) and any SynExpr.Const arguments.
This is a bit broader of a change than strictly speaking would be required. The only required change to prevent soundness bugs would be to detect if the const was a negative number in some form and apply spacing then, because the core bug is that removing the spacing transforms the expression from
+ (-2)to+- 2in meaning, so the operator being applied changes. I think it's reasonable to enforce a single-space everywhere, and if necessary we could encode this in the style guide.