Explain what's needed to close issues, that aren't reproducable anymore. #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
requested changes
Feb 13, 2022
| @@ -182,8 +185,8 @@ It's often better to check *before* contributing that you're setting off on the | |||
| ## Fixing style guide inconsistencies | |||
|
|
|||
| Fantomas tries to keep up with the style guides, but as these are living documents, it can occur that something is listed in the style that Fantomas is not respecting. | |||
| In this case, please create an issue using our [online tool](https://fsprojects.github.io/fantomas-tools/#/). | |||
There was a problem hiding this comment.
I think you've removed a couple of these in other PR's (perhaps automatically via tooling), but please don't remove these spaces.
They introduce a line break (<br /> HTML element).
There was a problem hiding this comment.
Oh, sorry. That's a setting in my VS Code. I'll keep that in mind.
|
Good reflex to add these little things to the contribution guidelines! |
nojaf
approved these changes
Feb 13, 2022
jindraivanek
pushed a commit
to jindraivanek/fantomas
that referenced
this pull request
Mar 30, 2022
…re. (fsprojects#2092) * Explain what's needed to close issues, that aren't reproducable anymore. * Put back trailing spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be worse it, to explain how we handle stale issues.