Fix 2151, index syntax without dot on array of arrays #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ElmishReactWithChildren matches
nojaf
reviewed
Mar 22, 2022
…shReactWithChildren into one
jindraivanek
pushed a commit
to jindraivanek/fantomas
that referenced
this pull request
Mar 30, 2022
* Fix 2151 (index syntax without dot on array of arrays) by taming what ElmishReactWithChildren matches * Combine APs for IndexWithoutDotExpr, ElmishReactWithoutChildren, ElmishReactWithChildren into one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2151
I think the source of the problem was that
ElmishReactWithChildrenwas matching too much, so I restricted it instead of changingIndexWithoutDotExpr.