Multiline parentheses objectExpression in indexer expression #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janus
changed the title
nojaf
requested changes
Apr 5, 2022
| @@ -2436,3 +2436,42 @@ async { | |||
| return model.Prop | |||
| } | |||
| """ | |||
|
|
|||
| [<Test>] | |||
| let ``Idempotency problem when using lower MaxLineLength than default, 2176`` () = | |||
There was a problem hiding this comment.
This problem is not related to computation expressions, please move to DotIndexedGetTests.
The test name should not start with an uppercase letter. See https://github.com/fsprojects/fantomas/blob/master/CONTRIBUTING.md#unit-test
The test name itself does also not cover what the problem case is.
Rename to multiline parentheses objectExpression in indexer expression, 2176
janus
force-pushed
the
removeAutoAddedParenInParen-squashed
branch
from
3f2134e
to
043a31f
Compare
Thanks. Done. |
nojaf
force-pushed
the
removeAutoAddedParenInParen-squashed
branch
from
043a31f
to
1c4b15c
Compare
nojaf
requested changes
Apr 6, 2022
janus
force-pushed
the
removeAutoAddedParenInParen-squashed
branch
from
1c4b15c
to
7e95864
Compare
nojaf
changed the title
janus
force-pushed
the
removeAutoAddedParenInParen-squashed
branch
from
7e95864
to
4ac7755
Compare
jindraivanek
pushed a commit
to jindraivanek/fantomas
that referenced
this pull request
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idempotency problem when using lower MaxLineLength than default and fantomas needs to split lines
Fixes #2176