Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long generic constraints #2273

Merged
merged 3 commits into from
May 24, 2022
Merged

Long generic constraints #2273

merged 3 commits into from
May 24, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented May 20, 2022

Hello @dsyme, this is an attempt to address #2267 and #2266.

I went with the original proposals to start somewhere.
At the verify least, the areas that need a change in Fantomas are found.

All in all, I don't think this is that bad and it looks consistent to me with #2263.

@knocte
Copy link
Contributor

knocte commented May 21, 2022

This seems related to #1133 too, maybe it covers it as well?

Copy link
Contributor

@dsyme dsyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nojaf nojaf merged commit 434df47 into fsprojects:master May 24, 2022
@nojaf nojaf deleted the fix-2266 branch May 24, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants