Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only call sepSpaceBeforeClassConstructor if we are generating a class #2284

Merged
merged 3 commits into from
May 30, 2022
Merged

only call sepSpaceBeforeClassConstructor if we are generating a class #2284

merged 3 commits into from
May 30, 2022

Conversation

dawedawe
Copy link
Member

Fixes #2226

nojaf
nojaf reviewed May 30, 2022
View reviewed changes
src/Fantomas.Core/CodePrinter.fs Outdated
@@ -3722,10 +3722,12 @@ and genTypeDefn
| TCSimple TCInterface -> Some range
| _ -> None

let isClass = interfaceRange = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, use Option.isNone instead.

nojaf
nojaf reviewed May 30, 2022
View reviewed changes
src/Fantomas.Core/CodePrinter.fs Outdated
@@ -3722,10 +3722,12 @@ and genTypeDefn
| TCSimple TCInterface -> Some range
| _ -> None

let isClass = interfaceRange = None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, use Option.isNone instead.

@nojaf
Copy link
Contributor

nojaf commented May 30, 2022

Thanks, good spot!

@nojaf nojaf merged commit 5e92752 into fsprojects:master May 30, 2022
@dawedawe dawedawe deleted the fix-2226 branch May 30, 2022 18:23
@panmona
Copy link
Contributor

panmona commented May 30, 2022

Awesome, thanks a lot for investigating and fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpaceBeforeClassConstructor inserts two spaces before explicit Interface definition
3 participants
@dawedawe @nojaf @panmona