Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Content after hash directive is lost. #2297

Closed
wants to merge 2 commits into from
Closed

Content after hash directive is lost. #2297

wants to merge 2 commits into from

Conversation

edgarfgp
Copy link
Contributor

Fixes #2293

  • Update collectTriviaFromDirectives endif to make it keeps the comments after formatting

@edgarfgp
Copy link
Contributor Author

What were the chances that @dawedawe and I submit a PR for the same issue with 5mins difference 😂

@dawedawe
Copy link
Member

What were the chances that @dawedawe and I submit a PR for the same issue with 5mins difference 😂

There's this german proverb: Zwei Dumme, ein Gedanke. Meaning something like: Two fools, one idea. 😄

@nojaf
Copy link
Contributor

nojaf commented Jun 21, 2022

Hey both! Amazing to see these PRs after a nice long weekend!
I went with @dawedawe because he added support for comments after the #else as well.
But I almost had to flip a coin to decide here 😸.

There's this german proverb: Zwei Dumme, ein Gedanke. Meaning something like: Two fools, one idea.

Wunderbar, that is coming on a t-shirt one day for sure 🤗

@nojaf nojaf closed this Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Content after hash directive is lost
3 participants
@edgarfgp @dawedawe @nojaf