Maintain column indentation for list of functions

[cgravill]

Fixes #2158

I wasn't sure about the added duplication in IndexWithoutDotExpr but factoring the change seemed to add as much complexity. Elsewhere seems to favour mild duplication. Happy to adjust as preferred.

Noticed in the ListTests.fs file the last function isn't marked as a test. I've checked and it runs fine. I have NOT added it to this PR but happy to or add a separate PR to get properly added and running:

fantomas/src/Fantomas.Core.Tests/ListTests.fs

Lines 2302 to 2321 in 2d5db3e

	let ``remove space between array type and square brackets, 2192`` () =
	formatSourceString
	false
	"""
	let x: int [] = [ 1, 2, 3 ]
	let x: double [] [] = [ [ 1.0, 2.0, 3.0 ] ]
	let foo (x: double []) (y: object [] []) : string [,] = x :> int []
	let foo<'T> (x: 'T []) = x
	"""
	config
	|> prepend newline
	|> should
	equal
	"""
	let x: int[] = [ 1, 2, 3 ]
	let x: double[][] = [ [ 1.0, 2.0, 3.0 ] ]
	let foo (x: double[]) (y: object[][]) : string[,] = x :> int[]
	let foo<'T> (x: 'T[]) = x
	"""

[nojaf]

Many thanks, @cgravill for picking this up!

Would you mind adding in a Changelog entry?
https://github.com/fsprojects/fantomas/blob/master/CONTRIBUTING.md#changelog
You will probably need to add the Unreleased header section.
And please include all duplicate issues in the changelog:

• Idempotency problem when Elmish Html #2195
• Splitting list results in code that doesn't compile #2201
• Idempotency problem when using a list with interpolated strings #2242
• Idempotency problem when using set and spread syntax #2392

There is no need to add tests for these duplicates as people should have added a space in the first place. But I'm considering all these closed and it should be recorded in the change log.

[nojaf]

Almost there, thanks for your patience.

[nojaf]

Please use the title of the issue instead of the title of the PR.
Similar to all the examples below.
And put each issue on its own line, the duplicates: is also somewhat strange compared to the rest.
Thanks

[cgravill]

Sure, done. I've not explicitly tested the others (as you requested above), but I've put them all on a separate line.

[cgravill]

Should I add them all to the fixes magic command?

[nojaf]

Many thanks, @cgravill!