Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style of base constructor calls. #2555

Merged
merged 2 commits into from Oct 7, 2022

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Oct 4, 2022

Update according to the guidance of fsharp/fslang-design#693.
Fixes fsharp/fslang-design#693.
Fixes #2111
Fixes #2335

@Smaug123 there is a minor impact for MultilineBlockBracketsOnSameColumn.
I don't think you really use that much. Nevertheless, does it seem acceptable?

@Smaug123
Copy link
Contributor

Smaug123 commented Oct 4, 2022

Am I right in thinking this doesn't affect { new obj() with... - only inherit calls? If so, I think we never use { inherit ... at all, so this should be fine.

@nojaf
Copy link
Contributor Author

nojaf commented Oct 4, 2022

Yup, object expressions are not affected by this.

@nojaf nojaf merged commit cabbcf4 into fsprojects:v5.1 Oct 7, 2022
@nojaf nojaf deleted the inherit-constructors branch October 7, 2022 19:23
nojaf added a commit that referenced this pull request Oct 13, 2022
* Change style of base constructor calls.

* Add changelog entry for 5.1.0-alpha-005.
nojaf added a commit that referenced this pull request Oct 13, 2022
* Change style of base constructor calls.

* Add changelog entry for 5.1.0-alpha-005.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants