Fix 143 #259
Fix 143 #259
Conversation
|
Hi @s-trooper! Thank you very much for this change. Unfortunately it also adds semicolons at line endings where they are not needed, like multi line records etc., even with SemicolonAtEndOfLine disabled. |
|
Hi @stroborobo, thank you for the report. I have fixed the problem. |
|
Hi @s-trooper , we looked at your PR. Looks good! Could you elaborate on the ignored unit tests? |
|
Hi @nojaf, i tested my RP by format the fantomas source, the ignored tests are some problems I had, that prevent the source code from being compiled after formatting. Since those issues are not caused by my RP (some stuff is related to F# Compiler Services), I used the ignored tests to document them for later. Probably I had to put these tests in a separate branch, should I do that? Or just ignore them when merging the RP. |
| let z = [7; 8] | ||
| """ { config with SemicolonAtEndOfLine = false } | ||
| |> should equal """ | ||
| let x = [ 1; |
There was a problem hiding this comment.
Just curious: why is this adding a ; when SemicolonAtEndOfLine = false is set? I guess it is unrelated to this PR
|
Hi @dsyme, it is so the "SemicolonAtEndOfLine" does not have a reliable (i don't see any?) effect on lists even in the master branch. Whereby I think that my code has a similar problem too, which was only covered by the master issue. I will think how this can be solved but my priority is that formatted code compiles. |
|
Hi @s-trooper , regarding the ignored tests. I'd prefer if they are left out of this PR. We could create separate issues if necessary. |
|
@nojaf, i've removed ignored tests |
This closes #143, this PR preserve original end of lines, disables auto insert/remove of EOLs by Formatter.
As it give control to line breaking to developer, it implicit solves #43, #130, #132, #133? but that of course depends of expectations of issue creators.