New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend logging and verbosity options #2693

Merged

nojaf merged 6 commits into fsprojects:v6.0 from dawedawe:fix-2627

Jan 15, 2023

Member

dawedawe commented Jan 6, 2023 •

edited

To show the general direction and maybe get some feedback, here's an early draft for the logging feature:
--verbosity d should be the same as in the past with the addition of the count of processed files in the end
--verbosity n should be pretty quiet

Fixes #2627


          First stab at logging.

f7034bb

--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

dawedawe changed the title ~~Logging.~~ Extend logging and verbosity options

dawedawe added 3 commits

January 7, 2023 16:24


          Make use of Serilog

44d9372


          improve test specificity

aedfbf8


          add log messages about count of processed files

ef51d9f

nojaf reviewed

View reviewed changes

Contributor

nojaf left a comment

This looks good so far!
I would be a little more consistent when using the logger functions. Just always go with an interpolated string. But that is really a nit.

I also think we should keep this for v6. Just to be on the safe side and get some user feedback.

src/Fantomas/IgnoreFile.fs Outdated Show resolved Hide resolved

src/Fantomas/Program.fs Outdated Show resolved Hide resolved

src/Fantomas/Program.fs Outdated Show resolved Hide resolved

src/Fantomas/Program.fs Outdated Show resolved Hide resolved

dawedawe added 2 commits

January 11, 2023 20:51


          Use interpolated strings for all logger functions.

83b5889

Change some logs to be error logs.


          Merge branch 'main' into fix-2627

f8d7fd8

Member Author

dawedawe commented Jan 11, 2023

This looks good so far! I would be a little more consistent when using the logger functions. Just always go with an interpolated string. But that is really a nit.

I also think we should keep this for v6. Just to be on the safe side and get some user feedback.

Thanks for the review. Waiting for v6 is fine for me.

TheAngryByrd mentioned this pull request

Adds naive parallel formatting implementation #2717

Merged

Contributor

nojaf commented Jan 15, 2023

I created a https://github.com/fsprojects/fantomas/tree/v6.0 branch which you can use to target this PR.

dawedawe changed the base branch from main to v6.0

January 15, 2023 11:28

dawedawe marked this pull request as ready for review

January 15, 2023 12:26

Member Author

dawedawe commented Jan 15, 2023

If this is okay, I'd like to merge this, so Jimmy and me run into less conflicts with our next steps.
I'm thinking about the changes needed to report in the end how many files failed and how many were good...

nojaf approved these changes

View reviewed changes

Contributor

nojaf left a comment

I think this is indeed ok to have as is now and revisit later.
Some food for thought:

Do we not want to show the user which file was formatted? I think this makes sense in normal logging.
Should we free up -v for verbosity? It is current used for version. It might make sense to use it for verbosity instead.
We will need to think about the format of logging. Seeing [15:21:11 INF] might be a bit misleading when detailed is active.

nojaf merged commit 1c2d6dd into fsprojects:v6.0

Member Author

dawedawe commented Jan 15, 2023

I think this is indeed ok to have as is now and revisit later. Some food for thought:

* Do we not want to show the user which file was formatted? I think this makes sense in normal logging.

* Should we free up `-v` for verbosity? It is current used for version. It might make sense to use it for verbosity instead.

* We will need to think about the format of logging. Seeing `[15:21:11 INF]` might be a bit misleading when `detailed` is active.

Thanks a lot, I'll work on these.

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

13596e0

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

d1262a9

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

6c7c451

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

b015ce0

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

ac3b07b

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

nojaf mentioned this pull request

Revisit --profile flag #2751

Closed

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

3719c5e

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

db7d82c

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

e93a2bf

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

ebd0a79

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

f889c9e

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

d2e54c2

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

ea60b22

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

e1c0926

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

nojaf pushed a commit that referenced this pull request


          Extend logging and verbosity options (#2693)

6933b99

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

nojaf pushed a commit that referenced this pull request


          Sunset MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupSty…

3d03227

…le (#2728)

* Extend logging and verbosity options (#2693)

* First stab at logging.
--verbosity d should be the same as in the past
--verbosity n should be pretty quiet

* Make use of Serilog

* improve test specificity

* add log messages about count of processed files

* Use interpolated strings for all logger functions.
Change some logs to be error logs.

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from src/

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Rider.md

* remove MultilineBlockBracketsOnSameColumn & ExperimentalStroustrupStyle from Configuration.fsx

* remove orange (use with caution) marker from fsharp_multiline_bracket_style

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment