Don't hook up SerilogTraceListener in FantomasDaemon. #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
added a commit
that referenced
this pull request
Feb 22, 2023
nojaf
added a commit
that referenced
this pull request
Mar 17, 2023
nojaf
added a commit
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the recent Serilog changes broke the daemon functionality.
Long story short when run
dotnet fantomas --daemon, with the latest alpha, you get:That
Listening started.ruins the whole communication protocol.I've added an explicit unit test to easier troubleshoot problems like this in the future.
Will release a new alpha if this build is green.