Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editorconfig package #2895

Merged
merged 2 commits into from
Jun 4, 2023
Merged

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jun 2, 2023

This uses a cache for parsing editor config files.
See editorconfig/editorconfig-core-net#23.
I tested this for Fantomas itself (200 files) and could see a slight improvement (50ms faster give or take). This would have more effect when with larger editor configs and nested scenarios.
Nonetheless worth having I think.

@nojaf nojaf requested a review from dawedawe June 2, 2023 18:39
Copy link
Member

@dawedawe dawedawe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@nojaf nojaf merged commit 20037f0 into fsprojects:v6.1 Jun 4, 2023
3 checks passed
nojaf added a commit that referenced this pull request Jun 19, 2023
* Use EditorConfigCache.

* Clean up EditorConfig.fs(i)
nojaf added a commit that referenced this pull request Jun 20, 2023
* Use EditorConfigCache.

* Clean up EditorConfig.fs(i)
nojaf added a commit that referenced this pull request Jun 20, 2023
* Use EditorConfigCache.

* Clean up EditorConfig.fs(i)
nojaf added a commit that referenced this pull request Jun 28, 2023
* Expose TransformAST api. (#2868)

* Expose TransformAST api.

* Add additional unit test.

* Revert changelog entry

* Add Changelog for 6.1 alpha 1

* Enrich transformed Oak. (#2869)

* Add Changelog for 6.1 alpha 2

* Rename FSharp.Compiler to Fantomas.FCS (#2894)

* Rename FSharp.Compiler to Fantomas.FCS

* Add release notes for 6.1.0-alpha-003.

* Update editorconfig package (#2895)

* Use EditorConfigCache.

* Clean up EditorConfig.fs(i)

* Add 6.1.0-alpha-004 to changelog.

* Add 6.1.0-alpha-005 to changelog.

* Add 6.1.0-alpha-006 to changelog.

* Add stable release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants