Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also accept alignment from if keyword in genKeepIdentIfThenElse. #2975

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Nov 2, 2023

See #2973.

@Smaug123 your desired result doesn't have a blank line after else:

module Program =
    let main _ =
        if false then
            1
        else
        printfn "hi!"
        0

We currently always add a blank line there. Do you want to change that behaviour as well?

@Smaug123
Copy link
Contributor

Smaug123 commented Nov 2, 2023

I'm very happy with adding the blank line. I was toying with the question; without the blank line it does look a bit cramped.

Copy link
Contributor

@Smaug123 Smaug123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the implementation, but the tests look like they're doing the right thing to me! Thanks.

@nojaf nojaf requested a review from dawedawe November 3, 2023 07:27
@nojaf nojaf merged commit 0aabadd into fsprojects:main Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants