Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extended interpolated strings #3052

Merged
merged 4 commits into from Mar 1, 2024

Conversation

dawedawe
Copy link
Member

@dawedawe dawedawe commented Feb 28, 2024

Fixes #3012

There's still something wrong with the lexer/parser and the produced range start of SynInterpolatedStringPart.String when there are multiple fill expressions.

Should be ready now.

- add tests for extended interpolated strings
@dawedawe dawedawe changed the title - update FCS to 2e95cbcc2cdf0317df6d5724cd62b15da4cea02b Add support for extended interpolated strings Feb 28, 2024
@dawedawe dawedawe marked this pull request as ready for review March 1, 2024 14:01
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@dawedawe dawedawe enabled auto-merge March 1, 2024 16:07
@dawedawe dawedawe merged commit d1c03c3 into fsprojects:main Mar 1, 2024
5 checks passed
@dawedawe dawedawe deleted the fix_3012 branch March 1, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fantomas does not support extended interpolated strings
2 participants