Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if expression is isArrayOrListWithHashDirectiveBeforeClosingBracket in indentSepNlnUnindentUnlessStroustrup #3071

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Check if expression is isArrayOrListWithHashDirectiveBeforeClosingBracket in indentSepNlnUnindentUnlessStroustrup #3071

merged 3 commits into from
Mar 30, 2024

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Mar 30, 2024

Fixes #3070

@nojaf
Check if expression is isArrayOrListWithHashDirectiveBeforeClosingBra…
919491f 
…cket in indentSepNlnUnindentUnlessStroustrup
@nojaf nojaf requested a review from josh-degraw March 30, 2024 09:56
@nojaf
Copy link
Contributor Author

nojaf commented Mar 30, 2024

Please review @josh-degraw

josh-degraw
josh-degraw approved these changes Mar 30, 2024
View reviewed changes
Copy link
Contributor

@josh-degraw josh-degraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@nojaf nojaf merged commit 25a9002 into fsprojects:main Mar 30, 2024
5 checks passed
@nojaf
Copy link
Contributor Author

nojaf commented Mar 30, 2024

Thanks

@nojaf nojaf mentioned this pull request Apr 15, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-degraw josh-degraw josh-degraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HashDirective before closing ]
2 participants
@nojaf @josh-degraw