Don't remove "in" from "let ... in ..." binding. #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please merge in master. Some tests are failing but I'm not sure that my changes caused this. |
|
Thanks for merging, I'm a bit puzzled why this test is suddenly failing. It doesn't work with 2.9 and I don't see why these changes would change this behavior. |
nojaf
approved these changes
Oct 30, 2018
| @@ -619,7 +619,11 @@ and genExpr astContext = function | |||
|
|
|||
| | TypeApp(e, ts) -> genExpr astContext e -- "<" +> col sepComma ts (genType astContext false) -- ">" | |||
| | LetOrUses(bs, e) -> | |||
| atCurrentColumn (genLetOrUseList astContext bs +> sepNln +> genExpr astContext e) | |||
| let isInSameLine = | |||
There was a problem hiding this comment.
Should we also check if the 'in' word was used in the original source code?
nojaf
added a commit
that referenced
this pull request
Oct 31, 2018
* Allow easy build/format/build cycle of external projects (#233) (#254) * Initial implementation of testing external projects (git clone, build, format, build again). For now tests with the Argu project which fails ATM * Improve building of external projects for regression testing. Add configuration function that allows platform specific configuration of external projects build exectuable and arguments TestExternalProjects is now dependent on Build only for faster testing Platform specific selection of Fanotmas executable from previous build step Shallow cloning of external repos for faster clones; switched to always cloning fresh repo instead of resetting * Fix 452 path * Attempt to add build stages to enable long running external tests on certain conditions in travisCI * Set sudo to true which will AFAIK disable container based builds * Switch back to container based builds, try Argu as an example external project on CI * Reverting sudo to true again since container builds take much more time in startup * Improve build script process name/args handling, fix paths for nix dotnet core testing * Cleanup of accidental changes vs master * More cleanup * Revert accidental whitespace changes in test file * Add testing of external projects only when on a branch named build-external-projects * Final cleanup and comments * Dummy commit to trigger rebuilds after github issues * Don't remove "in" from "let ... in ..." binding. (#342) * test * Use "let .. in .." if pattern and expr are at the same line. * Added fix for comment after in * Revert removed lines from fsproj * Merge fix * Fixed failing tests * add external projects, TestExternalProjectsFailing target, allow to specify project (#338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #340.
Result of pair programming with @nojaf on FableConf :)