Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each pattern is on a newline. #391

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Each pattern is on a newline. #391

merged 1 commit into from
Jan 17, 2019

Conversation

nojaf
Copy link
Contributor

@nojaf nojaf commented Jan 16, 2019

Improves #283.

@jindraivanek
Copy link
Contributor

Agree with this, however we should consider implement "If the expression is short, you can consider using a single line if each subexpression is also simple" from style guide.

Maybe open another issue for that?

@nojaf
Copy link
Contributor Author

nojaf commented Jan 17, 2019

Not sure,

you can consider using ...

not the strongest of wording that it should be on the same line if it is short.
Now it always obviously consistent, I personally prefer that. However feel free to make an issue if you disagree.

@nojaf nojaf merged commit 44a4bfc into fsprojects:master Jan 17, 2019
@nojaf nojaf deleted the pattern-match branch January 17, 2019 10:14
@jindraivanek jindraivanek mentioned this pull request Jan 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jindraivanek jindraivanek jindraivanek approved these changes

Assignees

@jindraivanek jindraivanek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nojaf @jindraivanek