Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump FCS to 28.0.0 and use net461 #436

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

nosami
Copy link
Member

@nosami nosami commented May 3, 2019

No description provided.

@nojaf
Copy link
Contributor

nojaf commented May 7, 2019

Hi @nosami, Travis is failing due to a network problem when downloading packages inside a container.
Could you add --network=host after both run command in .travis.yml? That could resolve the issue.

@nosami
Copy link
Member Author

nosami commented May 7, 2019

Ok. Done! No idea if that is right. Will soon see :)

@nojaf
Copy link
Contributor

nojaf commented May 7, 2019

Hi @nosami, thanks your change is exactly what it should be.
However, I just received word from Travis that the workaround shouldn't be needed anymore:
image
Could you revert the last change please? Sorry this is such a hassle.

This reverts commit d30d7e3c09e8f63e651dbb5c379ed3c9fd4538ba.
@nosami
Copy link
Member Author

nosami commented May 8, 2019

No problem! Let's see if this works.

@nojaf nojaf merged commit 6b2133c into fsprojects:master May 8, 2019
@nojaf
Copy link
Contributor

nojaf commented May 8, 2019

Thanks, if you need it you can find the latest version on MyGet for now. It might take some time until the next official version is released.

@nosami nosami deleted the fcs-28.0.0 branch May 8, 2019 09:51
@nosami
Copy link
Member Author

nosami commented May 8, 2019

@nojaf is it possible to add a build number or date to the package version on MyGet? I can't target a specific version on the nightly feed which makes reproducible builds a problem.

This update caused the VSMac master build to break because I was already using 2.9.2-latest and this update caused the TargetFramework to change :) Easily fixed but could happen again.

@nojaf
Copy link
Contributor

nojaf commented May 8, 2019

Yeah this is a bit unfortunate indeed.
So the reasoning behind the -latest is that people can easily copy the installation line on the README to install pre-release as a global tool.
You need the --version part otherwise the stable from MyGet will be installed.

I will change the version in the build script. so that it more like 9.2.1-alpha001.

@nojaf
Copy link
Contributor

nojaf commented May 8, 2019

@nosami could you try https://www.myget.org/gallery/fantomas?

@nosami
Copy link
Member Author

nosami commented May 8, 2019

@nojaf Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants