single line comment trivia treated same as new line trivia (partial fix for issue #513) #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoothdeveloper
changed the title
jindraivanek
approved these changes
Oct 20, 2019
nojaf
reviewed
Oct 21, 2019
nojaf
requested changes
Oct 21, 2019
|
No problem @nojaf will complete the changes at the end of the day. Thanks for quick turnaround. |
nojaf
approved these changes
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to run the tests green and fix the minimal case of #513, it doesn't fix all the issues formatting the code that was submitted though, so additional cases needs to be identified, #527 is another issue encountered formatting https://github.com/knocte/geewallet codebase.