Preserve return attribute #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontomondo
commented
May 16, 2020
nojaf
reviewed
May 17, 2020
nojaf
reviewed
May 17, 2020
kontomondo
commented
May 17, 2020
|
@nojaf is there anything else needed for this to get merged ? |
nojaf
requested changes
May 22, 2020
src/Fantomas/CodePrinter.fs
Outdated
| @@ -489,7 +489,7 @@ and genExprSepEqPrependType astContext (pat:SynPat) (e: SynExpr) (valInfo:SynVal | |||
| let genMetadataAttributes ctx = | |||
There was a problem hiding this comment.
You could leave the ctx parameter all together and return partially applied from both clauses.
There was a problem hiding this comment.
@kontomondo could you change this to:
let genMetadataAttributes =
match valInfo with
| Some(SynValInfo(_, SynArgInfo(attributes, _, _))) -> genOnelinerAttributes astContext attributes
| None -> sepNoneThere was a problem hiding this comment.
absolutely, done
nojaf
approved these changes
May 22, 2020
|
Many thanks @kontomondo! Sorry for the delay. |
|
@nojaf Thank you, and no worries, that was blazingly fast by open source standards :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #800