Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests with no result now yields a response with empty result #40

Merged

Conversation

mrbech
Copy link
Contributor

@mrbech mrbech commented Jan 26, 2019

So similarly to #39 I also ran into that https://github.com/natebosch/vim-lsc sends a "shutdown" request, waits for a response (with timeout of 5 seconds) and then sends an "exit" to the language server. With this language server, it times out (so vim takes 5 seconds to close).

This is because the fsharp language server does not respond to requests where there is no result (like "shutdown"), the specification (https://microsoft.github.io/language-server-protocol/specification) defines:

Every processed request must send a response back to the sender of the request.

So I made the change here and tested with vim-lsc and it works :)
As I see it this shouldn't create any issues with other clients.

@georgewfraser georgewfraser merged commit 101ef93 into fsprojects:master Jan 27, 2019
@georgewfraser
Copy link
Collaborator

Thanks!

georgewfraser added a commit that referenced this pull request Jan 27, 2019
@georgewfraser
Copy link
Collaborator

@mrbech would you mind checking this all still works after ec7f63f

@mrbech
Copy link
Contributor Author

mrbech commented Jan 27, 2019

Still works, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants