Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create github releases #82

Open
forki opened this issue Sep 19, 2014 · 16 comments
Open

Create github releases #82

forki opened this issue Sep 19, 2014 · 16 comments
Labels

Comments

@forki
Copy link
Member

forki commented Sep 19, 2014

See fsprojects/Paket@68704bc and fsprojects/Paket@d33887d#diff-6074983490330a0aac1bd23c958232d7R282

It would not be that hard. If we want to do it.

@forki forki added the question label Sep 19, 2014
@pblasucci
Copy link
Collaborator

Hmm... I'm torn. Part of me likes the idea; I think it'd simplify certain use cases. But part of me never intended for the scaffold to require versioning. It was intended to be a learning tool (as much as it is a timesaver) for folks. So I guess I could see it argues either way.

@forki
Copy link
Member Author

forki commented Sep 19, 2014

I thought the idea was to provide a opionated way to build (F#) projects?!

@dsyme
Copy link
Contributor

dsyme commented Sep 19, 2014

I agree with @forki that the project has now really become "the opinionated template for F# community projects". Not sure you intended that @pblasucci but it's a great thing :)

I'm not sure about GitHub releases, was looking at it but need to dig more

@forki
Copy link
Member Author

forki commented Sep 19, 2014

Ok regarding github.com releases:

  • it's always available (at least compared to nuget.org which goes down regularly)
  • you can download by clicking on website or using simple https client

@pblasucci
Copy link
Collaborator

Okay. I've thought about it some more...
:-)
Let's do it. Having releases will avoid confusion in case the scaffold "changes opinions".

Of course, I won't really have time for this until next week.

@forki
Copy link
Member Author

forki commented Sep 19, 2014

After reading your reply. I don't want releases for the scaffolding
project. I want to scaffold code which allows the generated projects to
push to github releases.
On Sep 19, 2014 5:55 PM, "Paulmichael Blasucci" notifications@github.com
wrote:

Okay. I've thought about it some more...
:-)
Let's do it. Having releases will avoid confusion in case the scaffold
"changes opinions".


Reply to this email directly or view it on GitHub
#82 (comment)
.

@pblasucci
Copy link
Collaborator

Whoops! I totally misunderstood your comment. Sorry... I'm trying to juggle too many things at once.

Now that I understand what you meant, I think it's fine to have multiple deployment targets (nuget, github, etc). Let's just make sure the number of choices stays manageable and is explained clearly in the docs.

@forki
Copy link
Member Author

forki commented Sep 19, 2014

Let's see how it works in Paket and then I will send a PR. Just wanted to
discuss this idea.

2014-09-19 18:02 GMT+02:00 Paulmichael Blasucci notifications@github.com:

Whoops! I totally misunderstood your comment. Sorry... I'm trying to
juggle too many things at once.

Now that I understand what you meant, I think it's fine to have multiple
deployment targets (nuget, github, etc). Let's just make sure the number of
choices stays manageable and is explained clearly in the docs.


Reply to this email directly or view it on GitHub
#82 (comment)
.

@dsyme
Copy link
Contributor

dsyme commented Sep 19, 2014

Hi @forki, could you add the "GitHub releases" to the most important F# community projects first, e.g. FSharp.Data and FSharp.Compiler.Service and maybe a few others? Just so we get a feel for what it means and start to spread it through the community, (I assume nuget package releases will still be used as well.)

@forki
Copy link
Member Author

forki commented Sep 19, 2014

will do.
At the moment I try to dogfood it in Github's octokit.

2014-09-19 18:37 GMT+02:00 Don Syme notifications@github.com:

Hi @forki https://github.com/forki, could you add the "GitHub releases"
to the most important F# community projects first, e.g. FSharp.Data and
FSharp.Compiler.Service and maybe a few others? Just so we get a feel for
what it means and start to spread it through the community, (I assume nuget
package releases will still be used as well.)


Reply to this email directly or view it on GitHub
#82 (comment)
.

@forki
Copy link
Member Author

forki commented Sep 19, 2014

actually after thinking about it I'm not sure if libs should go to github releases.
Maybe it's more for apps. Still thinking about it.

@tpetricek
Copy link
Member

In some of my projects (F# Formatting, RProvider?, Deedle?) we actually push release binaries to release branch so that the binaries can be easily downloaded somewhere (which is indeed totally wrong). If GitHub releases provide an easy to use replacement for this then I really like the idea!

If I can get a free PR from @forki for F# formatting, that would be awesome :-)

@forki
Copy link
Member Author

forki commented Sep 19, 2014

git

@forki
Copy link
Member Author

forki commented Sep 19, 2014

let's start with fsprojects/FSharp.Formatting#197

afterwards I will add github releases

@dungpa
Copy link
Contributor

dungpa commented Sep 20, 2014

@forki Would you mind to send a PR adding GitHub releases to VFPT :-)? Whenever we update a new version to VS Gallery, the old binaries disappeared. It's great to be able to use GitHub releases for archiving old binaries.

@forki
Copy link
Member Author

forki commented Sep 20, 2014

lol.

Maybe after we get
fsprojects-archive/zzarchive-VisualFSharpPowerTools#713 working ;-)

2014-09-20 12:40 GMT+02:00 Anh-Dung Phan notifications@github.com:

@forki https://github.com/forki Would you mind to send a PR adding
GitHub releases to VFPT :-)? Whenever we update a new version to VS
Gallery, the old binaries disappeared. It's great to be able to use GitHub
releases for archiving old binaries.


Reply to this email directly or view it on GitHub
#82 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants