Skip to content
This repository has been archived by the owner on Jan 3, 2019. It is now read-only.

Check files that have not been saved yet. #602

Merged
merged 4 commits into from
Jun 30, 2014
Merged

Check files that have not been saved yet. #602

merged 4 commits into from
Jun 30, 2014

Conversation

rojepp
Copy link
Contributor

@rojepp rojepp commented Jun 29, 2014

Do it by implementing IFileSystem, which FSC uses for file access.
A dictionary is kept to give consistent change times, so that FSC avoids rechecking.

Manual tests are at https://github.com/rojepp/FsManualTest

@rojepp
Copy link
Contributor Author

rojepp commented Jun 29, 2014

Note - the json TP in the tests will not update when you edit the json file, this TP does its own file reading, and does not use the shim.

@7sharp9
Copy link
Member

7sharp9 commented Jun 29, 2014

There's docs saying TP's are except from the virtual file system.

On 29 Jun 2014, at 16:35, Robert Jeppesen notifications@github.com wrote:

Note - the json TP in the tests will not update when you edit the json file, this TP does its own file reading, and does not use the shim.


Reply to this email directly or view it on GitHub.

@7sharp9
Copy link
Member

7sharp9 commented Jun 29, 2014

I'll merge after I test :-)

Thanks Robert!!!

@rojepp
Copy link
Contributor Author

rojepp commented Jun 30, 2014

For finding references, we save dirty documents: https://github.com/fsharp/fsharpbinding/blob/9afcedabd95dae138b48d655623e7a769ffda616/monodevelop/MonoDevelop.FSharpBinding/FSharpReferenceFinderExtension.fs#L61

I've never liked that, and with this change, we should be able to stop doing that. I'll try it tonight and update the PR if it works.

@7sharp9
Copy link
Member

7sharp9 commented Jun 30, 2014

Im just trying it out now, will merge shortly ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants