Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for checking unsaved files, same as in XS/VS #6

Closed
rojepp opened this issue May 26, 2015 · 2 comments · Fixed by #8
Closed

Add support for checking unsaved files, same as in XS/VS #6

rojepp opened this issue May 26, 2015 · 2 comments · Fixed by #8

Comments

@rojepp
Copy link
Contributor

rojepp commented May 26, 2015

IFileSystem should be implemented, as was done in XS here: fsprojects/zarchive-fsharpbinding#602

FSAC would then keep a list of modified file contents, and present those as fact to FCS via IFileSystem.
Editors are already sending modified file contents, so implementing this would improve error checking without editors needing to change anything.
@rojepp
Copy link
Contributor Author

rojepp commented May 26, 2015

I'd be happy to take a stab at this.

@rneatherway
Copy link
Contributor

@rojepp This would be very welcome, thanks! I will test and review any PR you send. It's been on my list for ages, but no idea when I would get to it myself...

@rojepp rojepp mentioned this issue May 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

POC: Implement multiple unsaved file checking
2 participants
@rneatherway @rojepp