-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
callback: guard against invalid values #441
Conversation
de5fc61
to
14b1c10
Compare
.github/workflows/docs.yml
Outdated
with: | ||
python-version: 3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, it'll use Python 3.12. versioneer.py
file needs to be updated for that to work with 3.12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skshetry Dropped versioneer, please rebase and you will be able to safely remove this.
Tests are failing, but seems unrelated. @efiop, could you please take a look at the PR? |
if not sent_total: | ||
if current is None: | ||
return | ||
if not sent_total and total is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sent_total
is not even being used here.
Should probably be set inside to True
, but 🤷🏽.
@skshetry Fixed CI, please rebase. |
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information. Also related: fsspec#275 (comment) and iterative/dvc#7704. Invalid values should not be passed to callbacks.
14b1c10
to
da77113
Compare
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information.
Also related: #275 (comment) and iterative/dvc#7704.
Invalid values should not be passed to callbacks.
cc @efiop