callback: guard against invalid values #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
guard-callback
branch
2 times, most recently
from
de5fc61
to
14b1c10
Compare
skshetry
commented
Dec 15, 2023
.github/workflows/docs.yml
Outdated
Comment on lines
15
to
16
| with: | ||
| python-version: 3.11 |
There was a problem hiding this comment.
Without this, it'll use Python 3.12. versioneer.py file needs to be updated for that to work with 3.12.
There was a problem hiding this comment.
@skshetry Dropped versioneer, please rebase and you will be able to safely remove this.
|
Tests are failing, but seems unrelated. @efiop, could you please take a look at the PR? |
skshetry
commented
Dec 15, 2023
| if not sent_total: | ||
| if current is None: | ||
| return | ||
| if not sent_total and total is not None: |
There was a problem hiding this comment.
sent_total is not even being used here.
Should probably be set inside to True, but 🤷🏽.
|
@skshetry Fixed CI, please rebase. |
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information. Also related: fsspec#275 (comment) and iterative/dvc#7704. Invalid values should not be passed to callbacks.
efiop
force-pushed
the
guard-callback
branch
from
14b1c10
to
da77113
Compare
efiop
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information.
Also related: #275 (comment) and iterative/dvc#7704.
Invalid values should not be passed to callbacks.
cc @efiop