Implement support for fsspec callbacks in put_file/get_file #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
@isidentical In your change you link to a comment Azure/azure-sdk-for-python#11419 (comment) explaining how to make a callback, but you don't follow it all the way. In particular this comment includes a check to see if current is None, which you omitted in your change. Why is that exactly? I'm asking because this is causing us trouble at the moment, please also see iterative/dvc#7704. |
skshetry
added a commit
to skshetry/adlfs
that referenced
this pull request
Dec 13, 2023
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information. Also related: fsspec#275 (comment) and iterative/dvc#7704. Invalid values should not be passed to callbacks.
skshetry
added a commit
to skshetry/adlfs
that referenced
this pull request
Dec 15, 2023
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information. Also related: fsspec#275 (comment) and iterative/dvc#7704. Invalid values should not be passed to callbacks.
skshetry
added a commit
to skshetry/adlfs
that referenced
this pull request
Dec 15, 2023
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information. Also related: fsspec#275 (comment) and iterative/dvc#7704. Invalid values should not be passed to callbacks.
efiop
pushed a commit
to skshetry/adlfs
that referenced
this pull request
Dec 23, 2023
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information. Also related: fsspec#275 (comment) and iterative/dvc#7704. Invalid values should not be passed to callbacks.
efiop
pushed a commit
that referenced
this pull request
Dec 23, 2023
See Azure/azure-sdk-for-python#11419 (comment) on how to get progress information. Also related: #275 (comment) and iterative/dvc#7704. Invalid values should not be passed to callbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for fsspec callbacks. It also removes some load from the
get_file:ls()call it is making on everyget_fileoperation, which is very costfulisdir()check, which is also very costful (if not cached) when considering it is done for everyget_fileespecially on Azure, since there are no directories per se.Resolves #276