support signed urls via connection string alone #478
Conversation
|
@martindurant hey, sorry for bothering you here, do you know who is the right person to check this and do a release? thanks! |
|
@hayesgb @TomAugspurger - who is maintaining this repo these days? |
|
Is it possible to make a test for this change? |
@martindurant yep, it has a test already |
|
@hayesgb @TomAugspurger @martindurant a friendly reminder folks :) |
|
It'll be a bit before I can take a look.
…________________________________
From: Ivan Shcheklein ***@***.***>
Sent: Thursday, June 27, 2024 11:04 AM
To: fsspec/adlfs ***@***.***>
Cc: Tom Augspurger ***@***.***>; Mention ***@***.***>
Subject: Re: [fsspec/adlfs] support signed urls via connection string alone (PR #478)
@hayesgb<https://github.com/hayesgb> @TomAugspurger<https://github.com/TomAugspurger> @martindurant<https://github.com/martindurant> a friendly reminder folks :)
—
Reply to this email directly, view it on GitHub<#478 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAKAOIQYIDRQ5B75UGRY4R3ZJQZZDAVCNFSM6AAAAABJRCKN4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJVGEYDENJRHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
| @@ -1541,11 +1542,19 @@ async def _url( | |||
| """ | |||
| container_name, blob, version_id = self.split_path(path) | |||
|
|
|||
| if self.connection_string: | |||
| args_dict = parse_connection_string(self.connection_string) | |||
There was a problem hiding this comment.
OK, I see what's going on here, looks good to me. One assumes the connected client also has this information, but since there's an upstream function to parse it, I don't see why we shouldn't use it.
There was a problem hiding this comment.
yep, thanks @martindurant for approving ... I hope maintainers will be able to take a look soon :)
|
just a friendly reminder folks, it would be great if we can merge this :) |
|
Thanks @shcheklein |
|
@TomAugspurger could you also trigger a new release please when you have a minute. Thanks! |
|
2024.7.0 is out on PyPI now: https://pypi.org/project/adlfs/ |
In a lot of cases we have only a connection and no account name, account key. Those could be extracted from the connection string and it's convenient to have it done automatically by the fs itself.