Change Alluxio configuration approach #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChunxuTang @jja725 PTAL, thanks! |
|
@jja725 @ChunxuTang PTAL, thanks! |
jja725
reviewed
Mar 12, 2024
| etcd_refresh_workers_interval (int, optional): The interval to refresh worker list from ETCD membership service periodically. | ||
| All negative values mean the service is disabled. | ||
| """ | ||
| if not (etcd_hosts or worker_hosts): |
There was a problem hiding this comment.
nit: I feel like a lot of these can ust use assert
| @@ -297,7 +275,10 @@ def update_loop(): | |||
| self._background_thread.start() | |||
|
|
|||
| def shutdown_background_update_ring(self): | |||
| if self._etcd_hosts and self._etcd_refresh_workers_interval > 0: | |||
| if ( | |||
There was a problem hiding this comment.
why change to self._config.etcd_hosts is not None
| self._options = options | ||
| self._hash_node_per_worker = hash_node_per_worker | ||
| self._max_attempts = max_attempts | ||
| self._config = config |
There was a problem hiding this comment.
I feel like we might still want to unwrap the config here like self._etcd_hosts = etcd_hosts and use the member value directly, like what we did in EtcdClient. What do you think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alluxio configuration duplicates in AlluxioClient and Alluxio fsspec AlluxioFileSystem.
To avoid the duplication, put the AlluxioClient in AlluxioClientConfig class.
All the arguments are passed all the way from AlluxioFileSystem -> AlluxioClient -> AlluxioClientConfig as **kwargs.