Make support for bz2 compression optional #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python may be compiled without bz2 support, in which case import of the
standard library module fails with a traceback like:
…/lib/python3.7/site-packages/fsspec/__init__.py:12: in <module>
from .compression import available_compressions
…/lib/python3.7/site-packages/fsspec/compression.py:2: in <module>
from bz2 import BZ2File
…/lib/python3.7/bz2.py:19: in <module>
from _bz2 import BZ2Compressor, BZ2Decompressor
ModuleNotFoundError: No module named '_bz2'
While rare, it does happen, so make the bz2 registration optional.
1 task
|
I hadn't realised _bz2 was not guranteeed. Thanks for posting this, it'll go in when green. |
|
Thanks! |
skshetry
added a commit
to iterative/PyDrive2
that referenced
this pull request
Jun 22, 2023
skshetry
added a commit
to iterative/PyDrive2
that referenced
this pull request
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python may be compiled without bz2 support, in which case import of the standard library module fails with a traceback like:
While rare, it does happen, so make the bz2 registration optional.