fix 400 errors on retries in _call #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kwargs was being overwritten by ._get_args. If any retries are needed, then on the second iteration datain will always be 'None'. This will cause uploading steps to return with exit code 400. This commit fixes this bug by refactoring the _call method to minimize the number of variabes in the scope. Resolves fsspec#290
nbren12
commented
Apr 28, 2021
| @@ -507,26 +528,9 @@ async def _call( | |||
| try: | |||
| if retry > 0: | |||
| await asyncio.sleep(min(random.random() + 2 ** (retry - 1), 32)) | |||
| self.maybe_refresh() | |||
| path, jsonin, datain, headers, kwargs = self._get_args( | |||
There was a problem hiding this comment.
note that kwargs is overwritten here. This is the bug.
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kwargs was being overwritten by ._get_args. If any retries are
needed, then on the second iteration datain will always be 'None'. This
will cause uploading steps to return with exit code 400.
This commit fixes this bug by refactoring the
_callmethod to minimizethe number of variabes in the scope.
Resolves #290